Change in vdsm[ovirt-3.6]: exception: Make VdsmException reusable

ybronhei at redhat.com ybronhei at redhat.com
Thu Feb 4 09:26:26 UTC 2016


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: exception: Make VdsmException reusable
......................................................................


exception: Make VdsmException reusable

VdsmException was initializing code and message to default values if
called without arguments. This make is useless as as base class for
more specific exceptions, defining real code and message.

GlusterException, the only exception inheriting from VdsmException,
avoided this issue by overriding __init__.

Required-For: https://bugzilla.redhat.com/1295778
Change-Id: Icd6643d9670cb9b067e372bf5a1a6c57ced41954
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/48875
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Continuous-Integration: Jenkins CI
Reviewed-on: https://gerrit.ovirt.org/52982
Tested-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Yaniv Bronhaim <ybronhei at redhat.com>
---
M lib/vdsm/exception.py
M tests/Makefile.am
A tests/exception_test.py
3 files changed, 35 insertions(+), 4 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Yaniv Bronhaim: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/52982
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd6643d9670cb9b067e372bf5a1a6c57ced41954
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>


More information about the vdsm-patches mailing list