Change in vdsm[master]: net: Fixing old netinfo access

danken at redhat.com danken at redhat.com
Wed Feb 3 16:23:31 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net: Fixing old netinfo access
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/53011/1/vdsm/virt/vmdevices/graphics.py
File vdsm/virt/vmdevices/graphics.py:

Line 205: def _getNetworkIp(network):
Line 206:     try:
Line 207:         nets = netinfo.networks()
Line 208:         device = nets[network].get('iface', network)
Line 209:         ip, _, _, _ = netinfo.addresses.getIpInfo(device)
can you add a call to this function from one of our *functional tests*? After setting up a network with an IP address, we need to assert that it returns the expected address.

we need to test this ugly function, somewhere, so this bug would not repeat.
Line 210:     except (libvirt.libvirtError, KeyError, IndexError):
Line 211:         ip = config.get('addresses', 'guests_gateway_ip')
Line 212:         if ip == '':
Line 213:             ip = '0'


-- 
To view, visit https://gerrit.ovirt.org/53011
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I37b61668eb8bda5a67b60e0d6b8ea92b524e8b45
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list