Change in vdsm[master]: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED

fromani at redhat.com fromani at redhat.com
Wed Feb 3 14:25:15 UTC 2016


Francesco Romani has uploaded a new change for review.

Change subject: periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED
......................................................................

periodic: ignore VIR_ERROR_OPERATION_UNSUPPORTED

libvirt sometimes raises it after migrations.
Need to investigate why it happens.

Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76
Signed-off-by: Francesco Romani <fromani at redhat.com>
---
M tests/periodicTests.py
M vdsm/virt/periodic.py
2 files changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/53056/1

diff --git a/tests/periodicTests.py b/tests/periodicTests.py
index b971810..d742dd7 100644
--- a/tests/periodicTests.py
+++ b/tests/periodicTests.py
@@ -248,6 +248,8 @@
         # errcode, migrating, last_status
         [libvirt.VIR_ERR_NO_DOMAIN, True, vmstatus.UP],
         [libvirt.VIR_ERR_NO_DOMAIN, False, vmstatus.DOWN],
+        [libvirt.VIR_ERR_OPERATION_UNSUPPORTED, True, vmstatus.UP],
+        [libvirt.VIR_ERR_OPERATION_UNSUPPORTED, False, vmstatus.DOWN],
     ])
     def test_swallow_exceptions(self, errcode, migrating, last_status):
 
diff --git a/vdsm/virt/periodic.py b/vdsm/virt/periodic.py
index 6ce8693..1b41d1c 100644
--- a/vdsm/virt/periodic.py
+++ b/vdsm/virt/periodic.py
@@ -304,6 +304,9 @@
             if e.get_error_code() in (
                 # race on shutdown/migration completion
                 libvirt.VIR_ERR_NO_DOMAIN,
+                # TODO: sometimes libvirt raises this on
+                # shutdown/migration completion
+                libvirt.VIR_ERR_OPERATION_UNSUPPORTED,
             ):
                 # known benign cases: migration in progress or completed
                 if migrating or self._vm.lastStatus == vmstatus.DOWN:


-- 
To view, visit https://gerrit.ovirt.org/53056
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I99de86a0b85c1caf8bb0eb30c37affe41738ba76
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>


More information about the vdsm-patches mailing list