Change in vdsm[master]: net: Clean netinfo.__init__ and migrate to cache

danken at redhat.com danken at redhat.com
Wed Feb 3 13:36:02 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: net: Clean netinfo.__init__ and migrate to cache
......................................................................


Patch Set 2:

(2 comments)

two nits

https://gerrit.ovirt.org/#/c/53007/2/lib/vdsm/netinfo/__init__.py
File lib/vdsm/netinfo/__init__.py:

Line 21: 
please keep this line - all new modules should have it, as it protects from Python 3 import errors.

I should enable the check enforcing this.


Line 48: 
this is not strictly related to cache - can it not stay here?

(also, its name is horrible - it tells very little - but this is unrelated to the patch)


-- 
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I892bb86fe9a8580d9028ca7759d27967e55d85f7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list