Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts
danken at redhat.com
danken at redhat.com
Wed Feb 3 10:40:28 UTC 2016
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
......................................................................
Patch Set 16:
(1 comment)
https://gerrit.ovirt.org/#/c/49505/16/vdsm/v2v.py
File vdsm/v2v.py:
Line 319:
Line 320: if rc != 0:
Line 321: # 1 = general fail
Line 322: # 2 = no agnet
Line 323: if rc == 1:
I suspect that the reverse logic is safer:
if rc != 2:
self._kill_agent()
Line 324: self._kill_agent()
Line 325: raise V2VError('Error init ssh-add, exit code: %r'
Line 326: ', out: %r, err: %r' %
Line 327: (rc, out, err))
--
To view, visit https://gerrit.ovirt.org/49505
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If544c0247003b6bc7189f72130553b9402dc915d
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list