Change in vdsm[ovirt-3.6]: exception: Make VdsmException reusable

fromani at redhat.com fromani at redhat.com
Wed Feb 3 08:45:17 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: exception: Make VdsmException reusable
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Looks OK. Please get another ack.

https://gerrit.ovirt.org/#/c/52982/1//COMMIT_MSG
Commit Message:

Line 12: 
Line 13: GlusterException, the only exception inheriting from VdsmException,
Line 14: avoided this issue by overriding __init__.
Line 15: 
Line 16: Required-For: https://bugzilla.redhat.com/1295778
We need a workflow or a gerrit fix for this, because you did the right thing using this tag, bug gerrit-hooks didn't recognize it. Let's discuss this on infra or devel lists later.
Line 17: Change-Id: Icd6643d9670cb9b067e372bf5a1a6c57ced41954
Line 18: Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Line 19: Reviewed-on: https://gerrit.ovirt.org/48875
Line 20: Reviewed-by: Francesco Romani <fromani at redhat.com>


-- 
To view, visit https://gerrit.ovirt.org/52982
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icd6643d9670cb9b067e372bf5a1a6c57ced41954
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list