Change in vdsm[master]: Kill and report asyncProc if fails on first write to stdin

danken at redhat.com danken at redhat.com
Tue Feb 2 12:55:35 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: Kill and report asyncProc if fails on first write to stdin
......................................................................


Patch Set 5:

(3 comments)

https://gerrit.ovirt.org/#/c/51763/5/lib/vdsm/commands.py
File lib/vdsm/commands.py:

Line 80: except
> I don't know how to be specific here .. if you can advice for something I c
we are not handling any specific exception here - we are cleaning up the process and letting the exception to bubble up - any exception. So I think that the use of pure "except:" is fair in this context.


Line 82: terminating
we do not really need the context manager here. exposing async_terminate() and running it here should be enough.


Line 83: six.reraise
we don't need the smart reraise


-- 
To view, visit https://gerrit.ovirt.org/51763
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I57b68742ce1dcae1d9fdad020b7b4a41ca6ad028
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list