Change in vdsm[master]: [wip] Dynamic load of supervdsm_api funcs
danken at redhat.com
danken at redhat.com
Tue Feb 2 12:36:54 UTC 2016
Dan Kenigsberg has posted comments on this change.
Change subject: [wip] Dynamic load of supervdsm_api funcs
......................................................................
Patch Set 4:
(4 comments)
https://gerrit.ovirt.org/#/c/52875/4/tests/functional/supervdsmFuncTests.py
File tests/functional/supervdsmFuncTests.py:
Line 31: dropPrivileges
running stuff on import is a bad practice (surprising users). why is the change needed?
https://gerrit.ovirt.org/#/c/52875/4/vdsm/supervdsm_api/dummy_funcs.py
File vdsm/supervdsm_api/dummy_funcs.py:
Line 21: ping
api_ping
rename module to "test" and include only in vdsm-tests.rpm
https://gerrit.ovirt.org/#/c/52875/4/vdsm/supervdsm_api/hwinfo.py
File vdsm/supervdsm_api/hwinfo.py:
Line 14: # along with this program; if not, write to the Free Software
Line 15: # Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
Line 16: #
Line 17: # Refer to the README and COPYING files for full details of the license
Line 18: #
please add
from future import absolute_import
and add all new modules to ABS_IMPORT_WHITELIST
Line 19: from vdsm import cpuarch
Line 20:
Line 21:
Line 22: def api_getHardwareInfo(self, *args, **kwargs):
https://gerrit.ovirt.org/#/c/52875/4/vdsm/supervdsm_api/network.py
File vdsm/supervdsm_api/network.py:
Line 29: return restore_nets.restore()
Line 30:
Line 31:
Line 32: def api_setupNetworks(self, networks, bondings, options):
Line 33: return setupNetworks(networks, bondings, **options)
please add setNumVfs
--
To view, visit https://gerrit.ovirt.org/52875
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67a1c349c15a03ba54788ffafd0c5b9d30ff7037
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list