Change in vdsm[master]: vmstats: remove useless short stacktrace

mpolednik at redhat.com mpolednik at redhat.com
Tue Feb 2 09:07:10 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: vmstats: remove useless short stacktrace
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/52894/3//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: vmstats: remove useless short stacktrace
Line 8: 
Line 9: There is no point in dumping a stacktrace
Line 10: when we miss cpu samples. Only adds noise.
Correct me if I'm wrong but the patch not only removes the stacktrace, but also logging of the fact itself. Could be worded nicely.
Line 11: 
Line 12: Change-Id: I69e12312e1c014c92de687fd6781dd83cbee709e
Line 13: Related-To: https://bugzilla.redhat.com/1299480
Line 14: Backport-To: 3.6


-- 
To view, visit https://gerrit.ovirt.org/52894
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I69e12312e1c014c92de687fd6781dd83cbee709e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list