Change in vdsm[master]: periodic: silence useless log

mpolednik at redhat.com mpolednik at redhat.com
Tue Feb 2 08:40:22 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: periodic: silence useless log
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/52895/3/vdsm/virt/periodic.py
File vdsm/virt/periodic.py:

Line 279:     def __init__(self, vm):
Line 280:         self._vm = vm
Line 281: 
Line 282:     @property
Line 283:     def suppress_errors(self):
Unless I'm missing something, a bit less verbose way of saying the same thing would be a class variable (e.g. cls._SUPPRESS_ERRORS). I myself would prefer that approach, but I'm fine with yours too.
Line 284:         return False
Line 285: 
Line 286:     @property
Line 287:     def runnable(self):


-- 
To view, visit https://gerrit.ovirt.org/52895
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3aa03074dbf91dd1c88e5f3fca74c2a907627670
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list