Change in vdsm[master]: Make DomainDescriptor use new XML API

fromani at redhat.com fromani at redhat.com
Mon Feb 1 15:24:43 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: Make DomainDescriptor use new XML API
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/52822/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: Make DomainDescriptor use new XML API
Line 8: 
Line 9: DomainDescriptor retrieves information about devices, based on provided
Line 10: domain XML.  Its job is to answer some questions about the devices, but
we could make it this way - and it would be nicer. But AFAIR DomainDescriptor was introduced to speed up things, with its API grown out of necessity.

I'm fine both extending DomainDescriptor and both having it as slim caching layer.
Line 11: not to perform XML/DOM processing (and even less taking care about
Line 12: various DOM implementations).  So let's pass the XML/DOM processing
Line 13: currently present in DomainDescriptor on the new XML API.
Line 14: 


-- 
To view, visit https://gerrit.ovirt.org/52822
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I50bb500b3508b4cdd6210e5fc425b8bd79dbd4f7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list