Change in vdsm[master]: Make VM._correctGraphicsConfiguration use DomainDescriptor

fromani at redhat.com fromani at redhat.com
Mon Feb 1 13:33:40 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: Make VM._correctGraphicsConfiguration use DomainDescriptor
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/52823/1/vdsm/virt/domain_descriptor.py
File vdsm/virt/domain_descriptor.py:

Line 68: 
Line 69:     def __init__(self, xmlStr):
Line 70:         super(DomainDescriptor, self).__init__(xmlStr)
Line 71:         self._xml = xmlStr
Line 72:         self._devices = super(DomainDescriptor, self).devices
why do we need this?
Line 73:         self._devices_hash = super(DomainDescriptor, self).devices_hash
Line 74: 
Line 75:     @property
Line 76:     def xml(self):


https://gerrit.ovirt.org/#/c/52823/1/vdsm/virt/vmdevices/graphics.py
File vdsm/virt/vmdevices/graphics.py:

Line 151:     def setupPassword(self, devXML):
Line 152:         attributes = {}
Line 153:         self._setPasswd(attributes)
Line 154:         for a, v in attributes.iteritems():
Line 155:             XML.set_attribute(devXML, a, v)
yes, this is better.
Line 156: 
Line 157: 
Line 158: def isSupportedDisplayType(vmParams):
Line 159:     display = vmParams.get('display')


-- 
To view, visit https://gerrit.ovirt.org/52823
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9583d81d3d561d806499b55aa64f733437800c4b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list