Change in vdsm[master]: periodic: ignore known-benign libvirt errors

fromani at redhat.com fromani at redhat.com
Mon Feb 1 09:19:54 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: periodic: ignore known-benign libvirt errors
......................................................................


Patch Set 4: -Code-Review

It is too fragile to make this per-domain and not per-operation.
Handling per-domain is too low level; it is the flow that knows (or can easily learn) if we are into a condition on which we can silently swallow the error. Doing this on global level (e.g. per domain) has a too high risk to hide unexpected errors, so real bugs.

-- 
To view, visit https://gerrit.ovirt.org/52884
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ifb5618f44870bdca97fa479734514a3c8d81c7d7
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list