Change in vdsm[master]: v2v: Detect VM with snapshots

nsoffer at redhat.com nsoffer at redhat.com
Fri Apr 29 22:46:49 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: v2v: Detect VM with snapshots
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/56574/4/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

Line 897:             i['model'] = model.get('type')
Line 898:         params['networks'].append(i)
Line 899: 
Line 900: 
Line 901: def _add_has_snapshots(vm, params):
> reads a little awkward, but I don't have better suggestions.
I would name this _add_snapshots_info to be consistent with other names here.
Line 902:     try:
Line 903:         ret = vm.hasCurrentSnapshot()
Line 904:     except libvirt.libvirtError:
Line 905:         logging.exception("Error checking for existing snapshots")


https://gerrit.ovirt.org/#/c/56574/4/tests/v2vTests.py
File tests/v2vTests.py:

Line 69:     def __init__(self, name="RHEL",
Line 70:                  vm_uuid="564d7cb4-8e3d-06ec-ce82-7b2b13c6a611",
Line 71:                  id=0,
Line 72:                  active=False,
Line 73:                  snapshots=False):
Naming this has_snapshot will make it clear that this is a boolean.
Line 74:         self._name = name
Line 75:         self._uuid = vm_uuid
Line 76:         self._mac_address = _mac_from_uuid(vm_uuid)
Line 77:         self._id = id


-- 
To view, visit https://gerrit.ovirt.org/56574
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9aa4de2faff92625cd0de8e3ae2a10a2d58aa823
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list