Change in vdsm[master]: storage: add block device naming tests

mpolednik at redhat.com mpolednik at redhat.com
Fri Apr 29 14:42:09 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: storage: add block device naming tests
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/56802/1/tests/vmStorageTests.py
File tests/vmStorageTests.py:

PS1, Line 641: '2'
> maybe you meant
Yes, done.


Line 641:             index='2',
Line 642:         )
Line 643: 
Line 644:         drive = Drive({}, self.log, **conf)
Line 645:         self.assertTrue(drive.name, expected_name)
> assertEqual would be more useful.
That was the mentally intended method. My fail. Done.
Line 646: 
Line 647: 
Line 648: def make_volume_chain(path="path", offset=0, vol_id="vol_id", dom_id="dom_id"):
Line 649:     return [{"leasePath": path,


-- 
To view, visit https://gerrit.ovirt.org/56802
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I492a1849109b6f852ccd015d487c6cb7441febdb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list