Change in vdsm[master]: vmdevices: make disk's makeName public
nsoffer at redhat.com
nsoffer at redhat.com
Thu Apr 28 23:22:15 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: vmdevices: make disk's makeName public
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56804/1/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:
Line 582: return alias, devPath, name
Line 583:
Line 584:
Line 585: def makeName(interface, index):
Line 586: devname = {'ide': 'hd', 'scsi': 'sd', 'virtio': 'vd', 'fdc': 'fd'}
> you lost 'sata' in the move
And the test did not break - this means that the tests are broken :-)
Line 587: devindex = ''
Line 588:
Line 589: i = int(index)
Line 590: while i > 0:
--
To view, visit https://gerrit.ovirt.org/56804
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35e11c52f86a4ed7155118607723e9e7712a08e7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list