Change in vdsm[master]: lvm: Use a constant to define default vg extent size
alitke at redhat.com
alitke at redhat.com
Thu Apr 28 15:43:20 UTC 2016
Adam Litke has posted comments on this change.
Change subject: lvm: Use a constant to define default vg extent size
......................................................................
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/56715/2//COMMIT_MSG
Commit Message:
Line 7: lvm: Use a constant to define default vg extent size
Line 8:
Line 9: The default vg extent size has so far been defined as "128m" by means of
Line 10: a default argument value in lvm.createVG. In order to test LVM we need
Line 11: to know this value progmatically. Define DEFAULT_VG_EXTENT_SIZE_MB in
> There is no DEFAULT_ now
updated message.
Line 12: storage.constants and use this value when a default is needed.
Line 13:
Line 14: Change-Id: I77d76e9c1011cb3bba41decbcb06830eaed66a6a
https://gerrit.ovirt.org/#/c/56715/2/vdsm/storage/lvm.py
File vdsm/storage/lvm.py:
Line 926
Line 927
Line 928
Line 929
Line 930
> This change is not related.
oops. Reverted.
Line 928: rc, out, err = _lvminfo.cmd(cmd, tuple(pvs))
Line 929: if rc != 0:
Line 930: raise se.PhysDevInitializationError(pvs[0])
Line 931:
Line 932: options = ["--physicalextentsize", "%im" % VG_EXTENT_SIZE_MB]
> %i works but not documented, use %d
Done
Line 933: if initialTag:
Line 934: options.extend(("--addtag", initialTag))
Line 935: cmd = ["vgcreate"] + options + [vgName] + pvs
Line 936: rc, out, err = _lvminfo.cmd(cmd, tuple(pvs))
--
To view, visit https://gerrit.ovirt.org/56715
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I77d76e9c1011cb3bba41decbcb06830eaed66a6a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list