Change in vdsm[master]: tests: Fix volume size handling in domain_manifest_test

alitke at redhat.com alitke at redhat.com
Thu Apr 28 15:05:40 UTC 2016


Adam Litke has uploaded a new change for review.

Change subject: tests: Fix volume size handling in domain_manifest_test
......................................................................

tests: Fix volume size handling in domain_manifest_test

This test module is not testing the rounding of volume sizes up to the
VG extent size (128M).  That is already tested in storagefakelibTests
and storage_volume_artifacts_test.  For this test, just use a large
enough size that will not need to be rounded.

Also, fix test_metaslot_selection which was not converting the volume
size to MB when calling the lvm createLV API.

Change-Id: I30a5d331585e916f3cfe0e698e1e30fb25539863
Signed-off-by: Adam Litke <alitke at redhat.com>
---
M tests/domain_manifest_test.py
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/20/56820/1

diff --git a/tests/domain_manifest_test.py b/tests/domain_manifest_test.py
index 202fdfc..e2a8475 100644
--- a/tests/domain_manifest_test.py
+++ b/tests/domain_manifest_test.py
@@ -29,8 +29,11 @@
 
 from storage import sd, blockSD, blockVolume
 
-VOLSIZE = 1048576
 MB = 1048576
+
+# We want to create volumes larger than the minimum block volume size
+# (currently 128M)
+VOLSIZE = 256 * MB
 
 
 class FileManifestTests(VdsmTestCase):
@@ -145,7 +148,7 @@
                    'ea13af29-b64a-4d1a-b35f-3e6ab15c3b04')
             for lv, offset in zip(lvs, [4, 7]):
                 sduuid = env.sd_manifest.sdUUID
-                env.lvm.createLV(sduuid, lv, VOLSIZE)
+                env.lvm.createLV(sduuid, lv, VOLSIZE / MB)
                 tag = blockVolume.TAG_PREFIX_MD + str(offset)
                 env.lvm.addtag(sduuid, lv, tag)
             with env.sd_manifest.acquireVolumeMetadataSlot(None, 1) as mdSlot:


-- 
To view, visit https://gerrit.ovirt.org/56820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I30a5d331585e916f3cfe0e698e1e30fb25539863
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>


More information about the vdsm-patches mailing list