Change in vdsm[master]: rpc: Make Bridge#_type_fixup more robust

mbetak at redhat.com mbetak at redhat.com
Thu Apr 28 14:30:08 UTC 2016


Martin Betak has posted comments on this change.

Change subject: rpc: Make Bridge#_type_fixup more robust
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56811/1/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:

Line 205:                 typefixups[symTypeName](item)
Line 206:             for (k, v) in symbol.get('data', {}).items():
Line 207:                 k = self._sym_name_filter(k)
Line 208:                 # first check if the 'item' supports indexing
Line 209:                 if isinstance(item, collections.Iterable) and k in item:
in case 'item' is an 'int' this fails with 

  TypeError: argument of type 'int' is not iterable
Line 210:                     self._type_fixup(k, v, item[k])
Line 211: 
Line 212:     def _fixup_args(self, className, methodName, args):
Line 213:         argDef = self.api['commands'][className][methodName].get('data', {})


-- 
To view, visit https://gerrit.ovirt.org/56811
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5871f6c08fe384f52bfa190a44290e2489f06981
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak <mbetak at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list