Change in vdsm[master]: cdrom: API change: require index

fromani at redhat.com fromani at redhat.com
Thu Apr 28 13:41:55 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: cdrom: API change: require index
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

-1 for backward compatibility concerns

https://gerrit.ovirt.org/#/c/56805/1/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

PS1, Line 6499: # @interface:   The bus used for cdrom
              : #
              : # @index:       Index on the bus used
not optional, so how do we handle the backward compatibility?


-- 
To view, visit https://gerrit.ovirt.org/56805
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I178c1a02bbad962f9dc9b67bed7691cf170ee896
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list