Change in vdsm[master]: virt: Add the migration/hibernation event handling (GuestAgent)

vfeenstr at redhat.com vfeenstr at redhat.com
Thu Apr 28 11:21:57 UTC 2016


Vinzenz Feenstra has posted comments on this change.

Change subject: virt: Add the migration/hibernation event handling (GuestAgent)
......................................................................


Patch Set 13: Verified+1

(1 comment)

https://gerrit.ovirt.org/#/c/51782/8/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 337:                     with SourceThread.ongoingMigrations:
Line 338:                         timeout = config.getint(
Line 339:                             'vars', 'guest_lifecycle_event_reply_timeout')
Line 340:                         if self.hibernating:
Line 341:                             self._vm.guestAgent.events.before_hibernation(
> nit: I prefer
ok
Line 342:                                 wait_timeout=timeout)
Line 343:                         elif self._enableGuestEvents:
Line 344:                             self._vm.guestAgent.events.before_migration(
Line 345:                                 wait_timeout=timeout)


-- 
To view, visit https://gerrit.ovirt.org/51782
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If298709e7c7788e33003643dbd628f4f48e55366
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list