Change in vdsm[master]: vm: handle destroy request while starting up

danken at redhat.com danken at redhat.com
Thu Apr 28 07:47:26 UTC 2016


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: handle destroy request while starting up
......................................................................


vm: handle destroy request while starting up

Since long time Vdsm allows Vm.destroy() requests
against VMs which are not yet fully created.
The most frequent use case is if the startup takes
lots of time, often because slow storage, so the
user decides to abort the startup.

Vdsm does the bare minimum to handle this flow,
and often misreports the Vm as down for error,
while it is not - the flow is supported.

To improve this situation, we add special explicit
handling for this case, and we add a new exitreason
to let Engine know that we had a destroy on startup.

Change-Id: I618eb03783d7059ae33d7b0a02542b99c8d8199b
Bug-Url: https://bugzilla.redhat.com/912390
Signed-off-by: Francesco Romani <fromani at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/55151
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/api/vdsmapi-schema.json
M lib/vdsm/virt/vmexitreason.py
M vdsm/virt/vm.py
3 files changed, 18 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified



-- 
To view, visit https://gerrit.ovirt.org/55151
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I618eb03783d7059ae33d7b0a02542b99c8d8199b
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list