Change in vdsm[master]: tests: let VDSM consume a bond created by nmcli

danken at redhat.com danken at redhat.com
Thu Apr 28 06:17:58 UTC 2016


Dan Kenigsberg has posted comments on this change.

Change subject: tests: let VDSM consume a bond created by nmcli
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/56059/9/tests/network/networkmanager.py
File tests/network/networkmanager.py:

PS9, Line 31: nettestlib
> There is a need to nicely split NM related functionality from test services
nm_controlled_bond is a test-only creature, that should move to nettestlib. the command-line wrappers _nmcli* should become public, be renamed (_nmcli prefix dropped) and stay in this module.


-- 
To view, visit https://gerrit.ovirt.org/56059
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7047ce59a515d0b8ed2c4c5307b4c0d47d4aa92b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list