Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

igoihman at redhat.com igoihman at redhat.com
Wed Apr 27 12:29:13 UTC 2016


Irit Goihman has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
......................................................................


Patch Set 10:

(6 comments)

https://gerrit.ovirt.org/#/c/53214/7/lib/vdsm/module_utils.py
File lib/vdsm/module_utils.py:

PS7, Line 2: 
> remove
Done


PS7, Line 28: 
> load_modules
Done


PS7, Line 32: 
            : 
            : 
> How about this?
Done


PS7, Line 35: 
            : 
> We need a more general behavior, I'm still looking at places in the project
Done


https://gerrit.ovirt.org/#/c/53214/7/lib/vdsm/tool/configurators/__init__.py
File lib/vdsm/tool/configurators/__init__.py:

Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: 
Line 21: from __future__ import absolute_import
Line 22: from vdsm.tool import UsageError
> It is preferred to do these type of changes changes in a separated patch, p
Done
Line 23: 
Line 24: 
Line 25: class InvalidConfig(UsageError):
Line 26:     """ raise when invalid configuration passed """


https://gerrit.ovirt.org/#/c/53214/7/tests/module_utils_tests.py
File tests/module_utils_tests.py:

PS7, Line 47: 
            : 
            : 
            : 
            : 
> We better not have print/s in a test.
Done


-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list