Change in vdsm[master]: virt: add device setup and teardown
nsoffer at redhat.com
nsoffer at redhat.com
Wed Apr 27 11:42:55 UTC 2016
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
......................................................................
Patch Set 12:
(1 comment)
Will review later
https://gerrit.ovirt.org/#/c/55135/12/tests/vmTests.py
File tests/vmTests.py:
Line 1108: self.assertFalse(devices[0].was_teardown)
Line 1109: self.assertTrue(devices[1].was_setup)
Line 1110: self.assertFalse(devices[1].was_teardown)
Line 1111: self.assertTrue(devices[2].was_setup)
Line 1112: self.assertFalse(devices[2].was_teardown)
Thanks, it is much easier to understand the tests now!
Line 1113:
Line 1114: def test_device_setup_fail_first(self):
Line 1115: devices = ([fake.Device('device_0', fail_setup=ExpectedError)] +
Line 1116: [fake.Device('device_{}'.format(i)) for i in range(1, 3)])
--
To view, visit https://gerrit.ovirt.org/55135
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f99b855de43cff693b99b6873a835b7ad56db1b
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list