Change in vdsm[master]: v2v: add support for importing kvm based vms from libvirt

nsoffer at redhat.com nsoffer at redhat.com
Wed Apr 27 11:27:46 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: v2v: add support for importing kvm based vms from libvirt
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/56459/2/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

Line 46
Line 47
Line 48
Line 49
Line 50
You can add soft dependency like this:

    try:
        import ovirt_image_common
    except ImportError:
        ovirt_image_common = None


Line 158:     if uri.startswith(_XEN_SSH_PROTOCOL):
Line 159:         command = XenCommand(uri, vminfo, job_id, irs)
Line 160:     elif uri.startswith(_VMWARE_PROTOCOL):
Line 161:         command = LibvirtCommand(uri, username, password, vminfo, job_id, irs)
Line 162:     elif uri.startswith(_KVM_PROTOCOL):
Fail here is ovir_image_common is None with UnsupportedError
Line 163:         command = KVMCommand(uri, username, password, vminfo, job_id, irs)
Line 164:     else:
Line 165:         raise ClientError('Unknown protocol for Libvirt uri: %s', uri)
Line 166:     job = ImportVm(job_id, command)


-- 
To view, visit https://gerrit.ovirt.org/56459
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0ddbab700f2e0c54d53ed02ec61477b92c9c7960
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list