Change in vdsm[master]: storage: organize imports in clusterlock.py

nsoffer at redhat.com nsoffer at redhat.com
Wed Apr 27 11:20:55 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: storage: organize imports in clusterlock.py
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56639/1/vdsm/storage/clusterlock.py
File vdsm/storage/clusterlock.py:

Line 28: from contextlib import nested
Line 29: 
Line 30: from vdsm import constants
Line 31: from vdsm import utils
Line 32: 
> That's not what you said a few days ago.
Don't believe anything I say :-)

Basically it depends on how many imports we have; if you have 12 vdsm imports and 7 vdsm.storage imports it makes sense to separate them, if you have only few of each, it does not.

It is all about how the code looks, and you should care about it.
Line 33: from vdsm.config import config
Line 34: from vdsm.storage import exception as se
Line 35: from vdsm.storage import misc
Line 36: 


-- 
To view, visit https://gerrit.ovirt.org/56639
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32d5787471e38cc5034bae50e2c922c825ba8e64
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list