Change in vdsm[master]: hostdev/sr-iov: use device setup instead of detach

fromani at redhat.com fromani at redhat.com
Wed Apr 27 10:29:09 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: hostdev/sr-iov: use device setup instead of detach
......................................................................


Patch Set 14: Code-Review-1

(1 comment)

minor thing, should be easy to fix

https://gerrit.ovirt.org/#/c/55137/14/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:

Line 39: 
Line 40:     def setup(self):
Line 41:         """
Line 42:         Detach the device from the host.
Line 43:         """
> Hm, I find it still confusing, perhaps it's better to omit the docstring wh
The docstring is confusing indeed. Please drop it.
Line 44:         logging.debug('Detaching device %s from the host.' % self.device)
Line 45:         self._deviceParams = detach_detachable(self.device)
Line 46: 
Line 47:     def getXML(self):


-- 
To view, visit https://gerrit.ovirt.org/55137
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1c97af2ea9f17ef38f9dbb4f41e5f9d1da9eebaa
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list