Change in vdsm[master]: net: OVS driver

edwardh at redhat.com edwardh at redhat.com
Wed Apr 27 09:59:47 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: OVS driver
......................................................................


Patch Set 19:

(1 comment)

https://gerrit.ovirt.org/#/c/55958/19/tests/network/ovs_driver_test.py
File tests/network/ovs_driver_test.py:

PS19, Line 194: TestOvsVsctlCommand.PROCESSED_VSCTL_LIST_BRIDGE_OUTPUT, cmd.result
> I find this utterly counter-intuitive. You set one value to the property an
It was very intuitive to me, the ability of python to provide such a setter and getter to look like an attribute, is the whole point of the @property feature.

But I really won't fight over it, I will just mention it is prettier my way.


-- 
To view, visit https://gerrit.ovirt.org/55958
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic24a9cea8d50e801de12da1c9cfcd2d195aed684
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list