Change in vdsm[master]: virt: Pass effective guest agent API version during migration

vfeenstr at redhat.com vfeenstr at redhat.com
Wed Apr 27 07:42:47 UTC 2016


Vinzenz Feenstra has posted comments on this change.

Change subject: virt: Pass effective guest agent API version during migration
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/53523/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS6, Line 291: pop
> I mean: do we need to _drop_ the key from the conf here?
pop because it is only available to migration destinations and gets the value _IF_ present and removes it from the conf (to keep it clean from 'temporary' items)


-- 
To view, visit https://gerrit.ovirt.org/53523
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e8625ad33f62852baa17cad377ab12065a52dec
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list