Change in vdsm[master]: Support initial_size parameter

nsoffer at redhat.com nsoffer at redhat.com
Tue Apr 26 19:47:54 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: Support initial_size parameter
......................................................................


Patch Set 3: Code-Review-1

(3 comments)

Looks good

https://gerrit.ovirt.org/#/c/56628/3/tests/storage_volume_artifacts_test.py
File tests/storage_volume_artifacts_test.py:

Line 247:             artifacts.commit()
Line 248:             self.assertRaises(OSError, artifacts.commit)
Line 249: 
Line 250:     @permutations([[0], [MB]])
Line 251:     def test_initial_size(self, initial_size):
test_initial_size_not_supported?
Line 252:         with self.fake_env() as env:
Line 253:             artifacts = env.sd_manifest.get_volume_artifacts(
Line 254:                 self.img_id, self.vol_id)
Line 255:             self.assertRaises(se.InvalidParameterException,


Line 324:             self.assertEqual(volume.PREALLOCATED_VOL, vol.getType())
Line 325: 
Line 326:     @permutations([[0], [volume.BLOCK_SIZE]])
Line 327:     def test_raw_volume_initial_size(self, initial_size):
Line 328:         # TODO: Write a test for COW volumes when support is added
Lets put the comment in the class level, where we will add the test
Line 329:         with self.fake_env() as env:
Line 330:             artifacts = env.sd_manifest.get_volume_artifacts(
Line 331:                 self.img_id, self.vol_id)
Line 332:             self.assertRaises(se.InvalidParameterException,


Line 331:                 self.img_id, self.vol_id)
Line 332:             self.assertRaises(se.InvalidParameterException,
Line 333:                               artifacts.create, *BASE_RAW_PARAMS,
Line 334:                               initial_size=initial_size)
Line 335: 
Here:

    # TODO: initial_size with cow format
Line 336:     def test_size_rounded_up(self):
Line 337:         # If the underlying device is larger the size will be updated
Line 338:         initial_size = (9 * MB) + 1024
Line 339:         expected_size = 10 * MB


-- 
To view, visit https://gerrit.ovirt.org/56628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I795d5c8e187252c95764ede998447c6524b37f91
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list