Change in vdsm[master]: tests: Add test_create_same_volume_in_image

nsoffer at redhat.com nsoffer at redhat.com
Tue Apr 26 15:55:13 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: tests: Add test_create_same_volume_in_image
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/56626/2/tests/storage_volume_artifacts_test.py
File tests/storage_volume_artifacts_test.py:

Line 27: 
Line 28: from vdsm.storage import exception as se
Line 29: 
Line 30: from storage import image, sd, volume
Line 31: import storage.sdm.api.create_volume
Are you sure we want to work with these absurd names?

This code will move soon to vdsm - so we will have:

    import vdsm.storage.sdm.api.create_volume

Why not:

    from storage.sdm.api import create_volume
Line 32: 
Line 33: 
Line 34: class ExpectedFailure(Exception):
Line 35:     pass


-- 
To view, visit https://gerrit.ovirt.org/56626
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad8d28d0ce115e935001aac558469cf10cbd5bec
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list