Change in vdsm[master]: hostdev: add support for SCSI

mpolednik at redhat.com mpolednik at redhat.com
Tue Apr 26 15:37:10 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: hostdev: add support for SCSI
......................................................................


Patch Set 7:

(3 comments)

https://gerrit.ovirt.org/#/c/55024/5//COMMIT_MSG
Commit Message:

PS5, Line 12: udev pat
> Sorry, what is an endpoint exactly? Could you please be more specific?
s/endpoint/udev\ path


https://gerrit.ovirt.org/#/c/55024/5/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:

PS5, Line 77: 
> why not just return a new correct one?
My call + leads to slightly nicer code inside hostdevice.py (we'd need to get the correct address *again* in setup routine).


https://gerrit.ovirt.org/#/c/55024/7/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:

PS7, Line 79:  Read adapter info from scsi host address, and mutate the adress (removing
            :     'host' key) to conform to libvirt.
            :     """
            :     adapter = 'scsi_host{}'.format(scsi_address['host'])
            :     scsi_address['unit'] = scsi_address['lun']
            :     del scsi_address['lun']
            :     del scsi_address['host']
            : 
            :     return {'name': adapter}
> same comment as ps5:
Forgot to submit a draft.

My call + leads to slightly nicer code inside hostdevice.py (we'd need to get the correct address *again* in setup routine).


-- 
To view, visit https://gerrit.ovirt.org/55024
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib049bc8669d3dc14a83c89c0d03f3410f242e1cd
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list