Change in vdsm[master]: tests: Add test_create_same_volume_in_image

nsoffer at redhat.com nsoffer at redhat.com
Tue Apr 26 15:23:59 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: tests: Add test_create_same_volume_in_image
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56626/1/tests/storage_volume_artifacts_test.py
File tests/storage_volume_artifacts_test.py:

Line 111:             artifacts.create(*BASE_RAW_PARAMS)
Line 112:             artifacts.commit()
Line 113:             artifacts = env.sd_manifest.get_volume_artifacts(
Line 114:                 self.img_id, self.vol_id)
Line 115:             parent = storage.sdm.api.create_volume.ParentVolumeInfo(
pyflakes fails because of this line.

Please do:

    from storage.sdm import create_volume

In the top of the module.
Line 116:                 dict(img_id=self.img_id, vol_id=self.vol_id))
Line 117:             params = BASE_COW_PARAMS + (parent,)
Line 118: 
Line 119:             self.assertRaises(se.VolumeAlreadyExists,


-- 
To view, visit https://gerrit.ovirt.org/56626
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad8d28d0ce115e935001aac558469cf10cbd5bec
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list