Change in vdsm[master]: storage: organize imports in clusterlock.py

nsoffer at redhat.com nsoffer at redhat.com
Tue Apr 26 15:10:29 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: storage: organize imports in clusterlock.py
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.ovirt.org/#/c/56639/1/vdsm/storage/clusterlock.py
File vdsm/storage/clusterlock.py:

Line 23
Line 24
Line 25
Line 26
Line 27
sanlock is not from the standard library, this is a 3rd party module that should have its own group after the stdlib imports.


Line 24
Line 25
Line 26
Line 27
Line 28
Put sanlock here with blank line after it.


Line 28: from contextlib import nested
Line 29: 
Line 30: from vdsm import constants
Line 31: from vdsm import utils
Line 32: 
we don't need to separate vdsm imports and vdsm.xxx imports.
Line 33: from vdsm.config import config
Line 34: from vdsm.storage import exception as se
Line 35: from vdsm.storage import misc
Line 36: 


-- 
To view, visit https://gerrit.ovirt.org/56639
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I32d5787471e38cc5034bae50e2c922c825ba8e64
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list