Change in vdsm[master]: v2v: Detect VM with snapshots

mpolednik at redhat.com mpolednik at redhat.com
Tue Apr 26 14:56:18 UTC 2016


Martin Polednik has posted comments on this change.

Change subject: v2v: Detect VM with snapshots
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

Minor things + the v2v test could really be made nicer (as suggested by yourself).

https://gerrit.ovirt.org/#/c/56574/1//COMMIT_MSG
Commit Message:

PS1, Line 9: v
f


https://gerrit.ovirt.org/#/c/56574/1/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

PS1, Line 4037: *
Marked as optional without #optional in the description, that doesn't seem right.


https://gerrit.ovirt.org/#/c/56574/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:

PS1, Line 901: _add_has_snapshots
The name could be improved, this wording is a bit awkward. _add_snapshot_flag (don't think that is an improvement though)?


-- 
To view, visit https://gerrit.ovirt.org/56574
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9aa4de2faff92625cd0de8e3ae2a10a2d58aa823
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list