Change in vdsm[master]: migrations: change convergence schedule from time to iterations

fromani at redhat.com fromani at redhat.com
Tue Apr 26 11:22:47 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: migrations: change convergence schedule from time to iterations
......................................................................


Patch Set 3: Code-Review-1

(6 comments)

-1 for visibility

https://gerrit.ovirt.org/#/c/56558/3//COMMIT_MSG
Commit Message:

PS3, Line 12: tha
the?


PS3, Line 12: alg
no need for abbreviations, we have plenty of space in the commit message


PS3, Line 28: e.g. if it is detected that the copying is in new
            : iteration it means the current downtime was not enough so the enlargement of
            : the downtime may make sense.
you mean that a new iteration needs to copy more data than the previous one?


PS3, Line 32: num
number


PS3, Line 33: num
number


PS3, Line 47:   - the current amount is equal or higher than the remembered => it is a new
            :     iteration because inside of one iteration the amount of memory has to
            :     slowly go down and can not stay at one point even less grow
so I'm now lost: how can we know if we are stalling or not?
If the memory to be copied grows, this means that we have begun a new iteration.
So a stall is just if we keep iterating "too much"? (for some sensible values of "too much")


-- 
To view, visit https://gerrit.ovirt.org/56558
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f87c954031842c35c99888c228a34ec7f19d800
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list