Change in vdsm[master]: hostdev: make _update_usb_device_info more generic

fromani at redhat.com fromani at redhat.com
Tue Apr 26 07:00:47 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: hostdev: make _update_usb_device_info more generic
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/55023/5/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:

Line 80: 
Line 81:         return hostdev
Line 82: 
Line 83:     @classmethod
Line 84:     def _update_unclear_device_info(cls, vm, device_conf, x):
"undecided" could be better than "unclear"? Your call.
Line 85:         alias = x.getElementsByTagName('alias')[0].getAttribute('name')
Line 86:         address = vmxml.device_address(x)
Line 87: 
Line 88:         # The routine is quite unusual because we cannot directly reconstruct


-- 
To view, visit https://gerrit.ovirt.org/55023
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a37a94dab06806b9f3b8baabce4cc4d9ed47c34
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list