Change in vdsm[master]: hostdev: use libvirt flags to select capability

fromani at redhat.com fromani at redhat.com
Tue Apr 26 06:36:46 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: hostdev: use libvirt flags to select capability
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

minor style comment

https://gerrit.ovirt.org/#/c/56037/3/lib/vdsm/hostdev.py
File lib/vdsm/hostdev.py:

PS3, Line 34: _LIBVIRT_DEVICE_FLAGS = {
            :     'system': 1,
            :     'pci': 2,
            :     'usb_device': 4,
            :     'usb': 8,
            :     'net': 16,
            :     'scsi_host': 32,
            :     'scsi_target': 64,
            :     'scsi': 128,
            :     'storage': 256,
            :     'fc_host': 512,
            :     'vports': 1024,
            :     'scsi_generic': 2048,
            : }
(sorry for late noticing)
Why can't just map our identifier to libvirt's constant?


-- 
To view, visit https://gerrit.ovirt.org/56037
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia40fff8ba0bace1272666825d6c4fce18ac9a1f0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list