Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

igoihman at redhat.com igoihman at redhat.com
Mon Apr 25 13:48:45 UTC 2016


Irit Goihman has posted comments on this change.

Change subject: Using pkgutil instead of redundant private funcs in configurator
......................................................................


Patch Set 7:

(2 comments)

https://gerrit.ovirt.org/#/c/53214/7/lib/vdsm/module_utils.py
File lib/vdsm/module_utils.py:

> Can we change the module name to moduleload or loadmodule?
The reason for calling it moduleUtils is to collect a few functions related to handling modules. I'm not sure if this module will only load modules in the future.
Line 1: #
Line 2: # Copyright 2008-2016 Red Hat, Inc.
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify


PS7, Line 35:         if not hasattr(modules[module_name], 'name'):
            :             setattr(modules[module_name], 'name', module_name)
> This is not useful for everyone, how about letting the caller choose if to 
We need a more general behavior, I'm still looking at places in the project where modules are loaded. will change it soon.


-- 
To view, visit https://gerrit.ovirt.org/53214
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec710e795aeaf5b611f6dbe4f8ea535c8be5fa14
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list