Change in vdsm[master]: virt: Set timeout on boot menu

mskrivan at redhat.com mskrivan at redhat.com
Mon Apr 25 10:07:03 UTC 2016


Michal Skrivanek has posted comments on this change.

Change subject: virt: Set timeout on boot menu
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

https://gerrit.ovirt.org/#/c/56393/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:

Line 240: 
Line 241:         ('boot_menu_timeout', '10',
Line 242:             'Boot menu timeout in seconds. '
Line 243:             'Minimum value is 0, maximum value is 65; if a different value '
Line 244:             'is given then it is adjusted to this range.'),
> Well, increased boot menu timeout is a feature that's not strictly needed, 
vdsm.conf is enough. No need to bother with UI, and still better than hardcoding
Line 245:     ]),
Line 246: 
Line 247:     # Section: [rpc]
Line 248:     ('rpc', [


https://gerrit.ovirt.org/#/c/56393/3/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

Line 302:             timeout = config.getint('vars', 'boot_menu_timeout') * 1000
Line 303:             if timeout < 0:
Line 304:                 timeout = 0
Line 305:             elif timeout > 65535:
Line 306:                 timeout = 65535
> If the configuration is invalid, we should log a warning about it or fail. 
or..just skip the 303-306; if you provide wrong value the wrong behavior you get. libvirt should protect us enough, eg. failing to run if invalid value is supplied
Line 307:             oselem.appendChildWithArgs('bootmenu', enable='yes',
Line 308:                                        timeout=unicode(timeout))
Line 309: 
Line 310:         if use_serial_console and cpuarch.is_x86(self.arch):


-- 
To view, visit https://gerrit.ovirt.org/56393
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f3501e8500e366e785f5a8ddfdf78fd34c997a2
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list