Change in vdsm[master]: mount: Simplify deleted suffix stripping

nsoffer at redhat.com nsoffer at redhat.com
Mon Apr 25 09:21:47 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: mount: Simplify deleted suffix stripping
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/56548/1/lib/vdsm/storage/mount.py
File lib/vdsm/storage/mount.py:

Line 61: 
Line 62:     if fs_file.endswith(_DELETED_SUFFIX):
Line 63:         fs_file = fs_file[:-len(_DELETED_SUFFIX)]
Line 64: 
Line 65:     fs_file = normpath(_parseFstabPath(fs_file))
> Why did you change the order ?
Thanks, fixed.
Line 66: 
Line 67:     return MountRecord(fs_spec, fs_file, fs_vfstype, fs_mntops,
Line 68:                        fs_freq, fs_passno)
Line 69: 


-- 
To view, visit https://gerrit.ovirt.org/56548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icb08af0a6a5e7202741cda8b39fe3cddac468b21
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list