Change in vdsm[master]: vdsm: changed relative imports to absolute imports

ybronhei at redhat.com ybronhei at redhat.com
Mon Apr 25 07:38:03 UTC 2016


Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm: changed relative imports to absolute imports
......................................................................


Patch Set 1:

(5 comments)

https://gerrit.ovirt.org/#/c/56536/1/lib/vdsm/tool/configurators/certificates.py
File lib/vdsm/tool/configurators/certificates.py:

Line 21: import sys
Line 22: 
Line 23: from vdsm.config import config
Line 24: 
Line 25: from . import YES, NO
from configurators import YES, NO
Line 26: from vdsm.tool.validate_ovirt_certs import validate_ovirt_certs
Line 27: from vdsm.constants import P_VDSM_EXEC, SYSCONF_PATH
Line 28: from vdsm.commands import execCmd
Line 29: from vdsm.utils import isOvirtNode


https://gerrit.ovirt.org/#/c/56536/1/lib/vdsm/tool/configurators/libvirt.py
File lib/vdsm/tool/configurators/libvirt.py:

Line 24: 
Line 25: from vdsm.config import config
Line 26: 
Line 27: from . import InvalidRun, NO, MAYBE
Line 28: from . certificates import CA_FILE, CERT_FILE, KEY_FILE
you can change the above as well ^
Line 29: from vdsm.tool.configfile import ConfigFile, ParserWrapper
Line 30: from vdsm.tool.validate_ovirt_certs import validate_ovirt_certs
Line 31: from vdsm import utils
Line 32: from vdsm import constants


https://gerrit.ovirt.org/#/c/56536/1/lib/vdsm/tool/configurators/multipath.py
File lib/vdsm/tool/configurators/multipath.py:

Line 24: import sys
Line 25: import tempfile
Line 26: import time
Line 27: 
Line 28: from . import YES, NO
same
Line 29: from vdsm.tool import service
Line 30: from vdsm import commands
Line 31: from vdsm import utils
Line 32: from vdsm import constants


https://gerrit.ovirt.org/#/c/56536/1/lib/vdsm/tool/configurators/sanlock.py
File lib/vdsm/tool/configurators/sanlock.py:

Line 21: import sys
Line 22: import grp
Line 23: import pwd
Line 24: 
Line 25: from . import YES, NO, MAYBE, InvalidConfig
same
Line 26: from vdsm import commands
Line 27: from vdsm import constants
Line 28: 
Line 29: SANLOCK_GROUPS = (constants.QEMU_PROCESS_GROUP, constants.VDSM_GROUP)


https://gerrit.ovirt.org/#/c/56536/1/lib/vdsm/tool/configurators/sebool.py
File lib/vdsm/tool/configurators/sebool.py:

Line 17: # Refer to the README and COPYING files for full details of the license
Line 18: #
Line 19: 
Line 20: from __future__ import absolute_import
Line 21: from . import YES, NO, MAYBE
same
Line 22: from vdsm import utils
Line 23: 
Line 24: 
Line 25: SEBOOL_ENABLED = "on"


-- 
To view, visit https://gerrit.ovirt.org/56536
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf42bbe589b1e18b789ad8e3137d320e3a3966a7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <irit.goihman at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list