Change in vdsm[master]: bridge: usage of yaml schema

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Sun Apr 24 19:15:23 UTC 2016


Piotr Kliczewski has posted comments on this change.

Change subject: bridge: usage of yaml schema
......................................................................


Patch Set 18:

(1 comment)

https://gerrit.ovirt.org/#/c/54528/18/lib/api/schemaapi.py
File lib/api/schemaapi.py:

PS18, Line 93: param.get('defaultvalue'),
             :                                    param.get('defaultvalue')
> It is strange, will fix.
After thinking again it is correct. We want to get default value from default_values for param.get('defaultvalue') but when the value is not there we want to use param ...


-- 
To view, visit https://gerrit.ovirt.org/54528
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list