Change in vdsm[master]: net: Ignore noqueue queuing discipline

edwardh at redhat.com edwardh at redhat.com
Sun Apr 24 12:04:10 UTC 2016


Edward Haas has posted comments on this change.

Change subject: net: Ignore noqueue queuing discipline
......................................................................


Patch Set 3: Verified+1

(1 comment)

https://gerrit.ovirt.org/#/c/56532/2/lib/vdsm/tc/__init__.py
File lib/vdsm/tc/__init__.py:

Line 173:     if out is None:
Line 174:         out = module.show(dev, **kwargs)
Line 175: 
Line 176:     for line in _parser.linearize(out.splitlines()):
Line 177:         if len(line) >= 2 and line[0] == 'qdisc' and line[1] == 'noqueue':
> is it relevant to 'class' and 'filter' as well? can "noqueue" appear on the
It is not possible to assign the noqueue queuing discipline to physical devices or classes.
But in general, we are not interested in this qdisc, so we just need to ignore it.

I guess that if someone defines a device named 'noqueue' we will have a problem.

The output looks like this:
qdisc noqueue 0: dev lo root refcnt 2
qdisc noqueue 0: dev edtest0 root refcnt 2

So we can check that the line starts with 'qdisc noqueue'
Line 178:             continue
Line 179:         tokens = iter(line)
Line 180:         _parser.consume(tokens, 'qdisc', 'class', 'filter')
Line 181:         yield module.parse(tokens)


-- 
To view, visit https://gerrit.ovirt.org/56532
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I80fba89a4fe9ddf705f2e4be8e56cab1af909f01
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Kaul <ykaul at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list