Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

nsoffer at redhat.com nsoffer at redhat.com
Fri Apr 22 20:32:26 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: Makefile: use tox to run make pep8 and pyflakes
......................................................................


Patch Set 7:

(3 comments)

https://gerrit.ovirt.org/#/c/49952/7/automation/check-patch.packages.el7
File automation/check-patch.packages.el7:

Line 14: python-inotify
Line 15: python-ioprocess
Line 16: python-netaddr
Line 17: python-nose
Line 18: python-tox
Maybe install this via pip?
Line 19: python-pthreading
Line 20: python-rtslib
Line 21: python-six
Line 22: python34-nose


https://gerrit.ovirt.org/#/c/49952/7/automation/check-patch.packages.fc23
File automation/check-patch.packages.fc23:

Line 13: python-inotify
Line 14: python-ioprocess
Line 15: python-netaddr
Line 16: python-nose
Line 17: python-tox
Maybe install via pip?
Line 18: python-pthreading
Line 19: python-six
Line 20: python3-netaddr
Line 21: python3-nose


https://gerrit.ovirt.org/#/c/49952/7/tox.sh
File tox.sh:

Line 19: PEP8_BLACKLIST=(config.py \
Line 20:                 constants.py \
Line 21:                 crossImportsTests.py \
Line 22:                 vdsm.py \
Line 23: 	       )
Unwanted tab
Line 24: 
Line 25: if [ 'pyflakes' = "$1" ]; then
Line 26:     (find . -path './.tox' -prune -type f -o \
Line 27:         -path './.git' -prune -type f -o \


-- 
To view, visit https://gerrit.ovirt.org/49952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id583de2d411bb5bcd0f717f569d2961b555334c9
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list