Change in vdsm[master]: virt: Don't set connected attribute in <graphics> if already...

nsoffer at redhat.com nsoffer at redhat.com
Fri Apr 22 19:47:30 UTC 2016


Nir Soffer has posted comments on this change.

Change subject: virt: Don't set connected attribute in <graphics> if already set
......................................................................


Patch Set 4:

(3 comments)

https://gerrit.ovirt.org/#/c/56224/4//COMMIT_MSG
Commit Message:

Line 19: 
Line 20: In theory, it prevents changing the attribute value from Engine after
Line 21: the VM has been started.  But we don't support such a feature now and
Line 22: we're probably not going to add it in a foreseeable future, so this
Line 23: limitation shouldn't matter.
This smells like the wrong place to fix. If we want to support shared sessions, why not fix engine to send connectionAction = "keep"?
Line 24: 
Line 25: Change-Id: Ie7c49b26675f06a4914e97d1d85f2355ee6a083c
Line 26: Bug-Url: https://bugzilla.redhat.com/1060573


https://gerrit.ovirt.org/#/c/56224/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3794
Line 3795
Line 3796
Line 3797
Line 3798
This change ignore the value of connAct, so engine lost control - silently.


Line 3801
Line 3802
Line 3803
Line 3804
Line 3805
If we keep this solution, please log a debug message here about ignoring connAct and keeping current session.


-- 
To view, visit https://gerrit.ovirt.org/56224
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7c49b26675f06a4914e97d1d85f2355ee6a083c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list