Change in vdsm[master]: net: OVS driver - bond_slave commands

phoracek at redhat.com phoracek at redhat.com
Fri Apr 22 12:22:24 UTC 2016


Petr Horáček has posted comments on this change.

Change subject: net: OVS driver - bond_slave commands
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/56449/1/lib/vdsm/network/ovs/driver/vsctl.py
File lib/vdsm/network/ovs/driver/vsctl.py:

Line 169:         command.extend(['add-bond', bridge, bond] + nics)
Line 170:         return Command(command)
Line 171: 
Line 172:     def attach_bond_slave(self, bond, slave):
Line 173:         if_cmd = ['--id=@%s' % slave, 'create', 'Interface', 'name=%s' % slave]
id has to be command-unique
Line 174:         port_cmd = ['add', 'Port', bond, 'interfaces', '@%s' % slave]
Line 175:         return Command(if_cmd), Command(port_cmd)
Line 176: 
Line 177:     def detach_bond_slave(self, bond, slave):


-- 
To view, visit https://gerrit.ovirt.org/56449
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iafe535a70139dc956594e5a30ce35509a9f8c467
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list