Change in vdsm[master]: virt: Pass effective guest agent API version during migration

vfeenstr at redhat.com vfeenstr at redhat.com
Fri Apr 22 12:17:51 UTC 2016


Vinzenz Feenstra has posted comments on this change.

Change subject: virt: Pass effective guest agent API version during migration
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/53523/4//COMMIT_MSG
Commit Message:

Line 12: 
Line 13: For the feature of lifecycle events for the guest it is needed that
Line 14: VDSM already knows the negotiated API version right from the moment
Line 15: of the migration completion so we can notify the guest about the
Line 16: completion of the migration.
> Ha, good point, I will make it min(MAX, passedversion)
Done
Line 17: 
Line 18: This will save VDSM from having to re-negotiate the API version,
Line 19: and allow us to send the guest agent the required information right
Line 20: away.


https://gerrit.ovirt.org/#/c/53523/5//COMMIT_MSG
Commit Message:

Line 22: In case the passed version is higher than supported, the loweest
Line 23: common maximum version will be chosen which will require
Line 24: negotiation later on, however it will give VDSM the ability to
Line 25: send the event anyway since it implies this feature to be present
Line 26: on both VDSM sides of the migration.
> I wrote an incorrect comment in PS4, sorry if I mislead you.
well if we restore it's like a migration from a older VDSM that doesn't know events, right?

In that case the version wouldn't be passed and results in an implicit version 0 => Cannot send events
Line 27: 
Line 28: Change-Id: I0e8625ad33f62852baa17cad377ab12065a52dec
Line 29: Bug-Url: https://bugzilla.redhat.com/1298120


-- 
To view, visit https://gerrit.ovirt.org/53523
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e8625ad33f62852baa17cad377ab12065a52dec
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list