Change in vdsm[master]: virt: Make DomainDescriptor use XML helpers

fromani at redhat.com fromani at redhat.com
Fri Apr 22 09:03:31 UTC 2016


Francesco Romani has posted comments on this change.

Change subject: virt: Make DomainDescriptor use XML helpers
......................................................................


Patch Set 3:

(1 comment)

I'm convinced that adding a (thin) wrapper layer is a good direction, probably our best shot atm.
I'm unsure about the actual implementation.
Extracting all the bits and reducing duplication *IS* a good thing, but I believe we should take additional steps and build a bit more infra.

https://gerrit.ovirt.org/#/c/55769/3/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:

PS3, Line 42:     :rtype: DOM object
the fact that we return a dom object (intentionally opaque) seem a quite strong call to pack all these functions into a class.

We could do a very thin wrapper, or perhaps we could just enhance domain_descriptor and make it higher level, e.g. returning device objects instead of XML elements.

What do you think?


-- 
To view, visit https://gerrit.ovirt.org/55769
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib169735936d19171ff8b8d127666d7258c308f34
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list